Discussion:
nextincr in krb5int_dns_init too small
Daniel Colascione
2016-02-18 12:46:39 UTC
Permalink
krb5int_dns_init has a conventional malloc-and-realloc-until-it-fits
loop, but inside the loop body, we're calling res_nsearch, which can do
non-trivial work. It'd be better to increase the initial guess from 2048
to something bigger; even 4k is a trivial amount of memory these days,
and I'm getting 2786-byte responses.
Greg Hudson
2016-02-22 21:29:44 UTC
Permalink
Post by Daniel Colascione
krb5int_dns_init has a conventional malloc-and-realloc-until-it-fits
loop, but inside the loop body, we're calling res_nsearch, which can do
non-trivial work. It'd be better to increase the initial guess from 2048
to something bigger; even 4k is a trivial amount of memory these days,
and I'm getting 2786-byte responses.
I am preparing a pull request to update the buffer size to 4K. Am I
correct to asssume that these 2786-byte responses include DNSSEC signatures?

_______________________________________________
krbdev mailing list ***@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev

Loading...